Skip to content

test: fail CI on dual-major react-query in RTV [AIS-33]#11076

Open
Jared Jolton (jjolton-contentful) wants to merge 2 commits into
masterfrom
fix/rtv-react-query-major-uniqueness
Open

test: fail CI on dual-major react-query in RTV [AIS-33]#11076
Jared Jolton (jjolton-contentful) wants to merge 2 commits into
masterfrom
fix/rtv-react-query-major-uniqueness

Conversation

@jjolton-contentful

@jjolton-contentful Jared Jolton (jjolton-contentful) commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

AIS-33

Summary

  • Add an install-tree CI gate for Rich Text Versioning that fails when more than one major of @tanstack/react-query is present under node_modules
  • Catches the dual-major tree (field-editor-reference hard-deps ^4 vs field-editor-rich-text@6 / field-editor-shared@4 peer-accepting ^4 || ^5) that Vite collapses to the wrong single major at bundle time — the embedded entry/asset card sys crash class
  • Unique-majors only (no forced 4.x pin); noted as a sharp edge in AGENTS.md

Test plan

  • npm run test:ci in apps/rich-text-versioning (36 tests green, including new gate)
  • Unit cases cover empty / single-major / dual-major (4+5) trees
  • Live walk of current node_modules asserts a single major
  • Confirm lerna --since still marks RTV changed on a package.json / lockfile dep bump so test:ci runs

Generated with Claude Code

Made with Cursor

Install-tree gate catches the field-editor-reference v4 vs shared/rich-text v5 split that Vite collapses to the wrong major at bundle time.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant