Skip to content

fix(net): break tx loop on non-recoverable errors to prevent busy-loop #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
areporeporepo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(net): break tx loop on non-recoverable errors to prevent busy-loop #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/devices/src/virtio/net/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,11 @@ impl NetWorker {
Err(TxError::Backend(WriteError::NothingWritten)) => true,
Err(e) => {
log::error!("Failed to process tx: {e:?}");
false
// Break immediately on non-recoverable errors to avoid a
// busy-loop when the guest keeps supplying TX buffers.
// The worker will be re-entered on the next TX queue kick
// or backend-writable event.
break;
}
_ => false,
};
Expand Down
Loading