Add 4 more integration tests to run with make test#179
Draft
dmcgowan wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Derek McGowan <derek@mcg.dev>
There was a problem hiding this comment.
Pull request overview
Updates the integration test execution so CI runs integration tests via the repository’s make test-integration wrapper (which uses integration/test.sh to run tests in separate processes, avoiding shutdown issues on some platforms).
Changes:
- Extend
integration/test.shto run four additional integration test cases individually. - Switch the GitHub Actions integration-test step from
go test -v ./integration/...tomake test-integration.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| integration/test.sh | Adds four more test names to the per-test execution list. |
| .github/workflows/ci.yml | Runs integration tests via make test-integration instead of direct go test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
267
to
+268
| - name: Run integration tests | ||
| run: go test -v ./integration/... | ||
| run: make test-integration |
Comment on lines
267
to
+268
| - name: Run integration tests | ||
| run: go test -v ./integration/... | ||
| run: make test-integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test.sh is used to run each test in its own process to prevent shutdown issues on some platforms.