ci: refactor workflow/kernel cache key + cache initrd#176
Open
ci: refactor workflow/kernel cache key + cache initrd#176
Conversation
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the CI workflows around cached VM artifacts: it centralizes kernel cache-key calculation, splits kernel builds by architecture, and adds initrd caching/artifact handoff so integration jobs can reuse prebuilt guest artifacts.
Changes:
- Extracts kernel cache-key generation into a reusable composite action and updates the benchmark workflow to use it.
- Splits CI kernel builds into separate x86_64 and arm64 jobs and forwards their cache keys into integration.
- Adds a dedicated initrd build/cache/upload job, then updates integration to restore the kernel, download the initrd artifact, build the shim locally, and run the integration script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Refactors CI job graph for kernel/initrd artifact reuse and updates integration execution. |
.github/workflows/benchmarks.yml |
Switches benchmark kernel cache-key calculation to the new reusable action. |
.github/actions/kernel-cache-key/action.yml |
Adds a composite action that computes deterministic kernel cache keys. |
.github/actions/build-kernel/action.yml |
Reuses the new cache-key action and exposes the computed key as an output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| kernel_version: ${{ needs.setup.outputs.kernel-version }} | ||
| kernel_arch: ${{ matrix.arch }} | ||
| path: _output/nerdbox-initrd | ||
| key: initrd-${{ matrix.arch }}-${{ hashFiles('go.sum', 'Dockerfile', 'cmd/vminitd/**', 'internal/**') }} |
Comment on lines
+274
to
279
| - name: Build shim | ||
| run: make _output/containerd-shim-nerdbox-v1 | ||
|
|
||
| - name: Add _output to PATH | ||
| run: echo "$(pwd)/_output" >> $GITHUB_PATH | ||
|
|
| - name: Run integration tests | ||
| run: go test -v ./integration/... | ||
| shell: bash | ||
| run: ./integration/test.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.