Fix incorrect trim of socket address prefix#113
Open
dmcgowan wants to merge 1 commit intocontainerd:mainfrom
Open
Fix incorrect trim of socket address prefix#113dmcgowan wants to merge 1 commit intocontainerd:mainfrom
dmcgowan wants to merge 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Derek McGowan <derek@mcg.dev>
There was a problem hiding this comment.
Pull request overview
Fixes creation of the shim socket’s parent directory on Unix by correctly stripping the unix:// scheme and deriving the directory path (instead of incorrectly trimming and taking the basename).
Changes:
- Correct
strings.TrimPrefixargument order when removingunix://from the socket address. - Use
filepath.Dir(...)(parent directory) rather thanfilepath.Base(...)(final path element) before callingos.MkdirAll.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arguments are backwards