Skip to content

return all errors from writeerror #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ingon merged 1 commit into from
Feb 22, 2026
+5 −5
Merged

return all errors from writeerror #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions proto/pbconnect/proto.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"io"

"github.com/connet-dev/connet/proto"
pberror "github.com/connet-dev/connet/proto/pberror"
"github.com/connet-dev/connet/proto/pberror"
)

func ReadRequest(r io.Reader) (*Request, error) {
Expand All @@ -28,9 +28,9 @@ func ReadResponse(r io.Reader) (*Response, error) {
}

func WriteError(w io.Writer, code pberror.Code, msg string, args ...any) error {
err := pberror.NewError(code, msg, args...)
if err := proto.Write(w, &Response{Error: err}); err != nil {
return fmt.Errorf("write err response: %w", err)
pbErr := pberror.NewError(code, msg, args...)
if err := proto.Write(w, &Response{Error: pbErr}); err != nil {
return fmt.Errorf("write err response '%w': %w", pbErr, err)
}
return err
return pbErr
}