Skip to content

fix(bin): add missing JAR directory to windows batch script#3553

Open
Alejandro G. Peregrina (agperegrina) wants to merge 7 commits intoconfluentinc:masterfrom
agperegrina:master
Open

fix(bin): add missing JAR directory to windows batch script#3553
Alejandro G. Peregrina (agperegrina) wants to merge 7 commits intoconfluentinc:masterfrom
agperegrina:master

Conversation

@agperegrina
Copy link
Copy Markdown

@agperegrina Alejandro G. Peregrina (agperegrina) commented Feb 7, 2025

What

Fixed the windows batch file in a way that Confluent Community Edition schema-registry works without docker. There are only symlinks—instead of the actual JARs for the needed dependencies—in the folders added to the :concat jump goto label that fills the %CLASSPATH%. Thus, this change adds the missing classes that are in the ksqldb directory solving this issue.

See also: confluentinc/kafka#1581

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Is this change gated behind feature flag(s)?
    • List the LD flags needed to be set to enable this change
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
  • Does this change require modifying existing system tests or adding new system tests?
    • If so, include tracking information for the system test changes

Test & Review

Before:
image

After
image

@confluent-cla-assistant
Copy link
Copy Markdown

confluent-cla-assistant Bot commented Feb 7, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ aogzpa
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@agperegrina Alejandro G. Peregrina (agperegrina) changed the title fix(bin): add missing JAR directory for windows batch script fix(bin): add missing JAR directory to windows batch script Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants