Skip to content

[APIE-933] Migrate the confluent environment commands exclude the integration test #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Channing Dong (channingdong) merged 3 commits into from
Aug 4, 2026
Merged

[APIE-933] Migrate the confluent environment commands exclude the integration test #3427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
426d87f
Migrate the confluent environment commands exclude the integration test
channingdong Jul 31, 2026
d85caf6
Use special auto-complete function for environment command
channingdong Aug 3, 2026
d5f8c5d
Address the non-human output parsing error for update commands
channingdong Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cli-generation-checksum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
58aefba2da0f8430afc48f085285b659c6c5c6f5f2069871a16aa4652ffa50f7
51a944df342166086f945fcb9381aed8c9f6f5d455de6d123f0f10f135c61070
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ require (
github.com/confluentinc/ccloud-sdk-go-v2/networking-gateway v0.7.0
github.com/confluentinc/ccloud-sdk-go-v2/networking-ip v0.2.0
github.com/confluentinc/ccloud-sdk-go-v2/networking-privatelink v0.3.0
github.com/confluentinc/ccloud-sdk-go-v2/org v0.12.0
github.com/confluentinc/ccloud-sdk-go-v2/org v0.13.0
github.com/confluentinc/ccloud-sdk-go-v2/provider-integration v0.2.0
github.com/confluentinc/ccloud-sdk-go-v2/rtce v0.1.0
github.com/confluentinc/ccloud-sdk-go-v2/service-quota v0.2.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,8 @@ github.com/confluentinc/ccloud-sdk-go-v2/networking-ip v0.2.0 h1:ZHNF2DeqVlNPuKG
github.com/confluentinc/ccloud-sdk-go-v2/networking-ip v0.2.0/go.mod h1:KTShFBZA7WG8LcxlWjJpoZFdWkJ+uOw3dDuwAHs5eKU=
github.com/confluentinc/ccloud-sdk-go-v2/networking-privatelink v0.3.0 h1:mC0E1nKUt57AxMM4Lpdfd+KA/YZwJVwro9ER+dCUFi8=
github.com/confluentinc/ccloud-sdk-go-v2/networking-privatelink v0.3.0/go.mod h1:GIHF2cYOUKx+6ycYokr4i8E4cuNBC22xqvO/IhqZ31U=
github.com/confluentinc/ccloud-sdk-go-v2/org v0.12.0 h1:c3oeexhk5MiIzh+frC5EH9OlkoqAZK8UYeyaQVbSA+M=
github.com/confluentinc/ccloud-sdk-go-v2/org v0.12.0/go.mod h1:f3KzqFA5c0PddJ5qe4MWxlEiZ2n1yhzwvmPsdfEU6dw=
github.com/confluentinc/ccloud-sdk-go-v2/org v0.13.0 h1:/H/6SmonnvOzhjLA/6xSTSvq6N/uMuoPc66VEp/qxV8=
github.com/confluentinc/ccloud-sdk-go-v2/org v0.13.0/go.mod h1:BNnhFTvGhJSbyaklv0YkoTDWUdiWppLyu2hzfdxOWYM=
github.com/confluentinc/ccloud-sdk-go-v2/provider-integration v0.2.0 h1:UN2a+aqYhk95ro+wVLkeB/8W7n+UV2KsE3jNFbbDCSw=
github.com/confluentinc/ccloud-sdk-go-v2/provider-integration v0.2.0/go.mod h1:TzompS9F0G6awN5xMC+nguNG8ULElN5UqX2XOBOIPuM=
github.com/confluentinc/ccloud-sdk-go-v2/rtce v0.1.0 h1:OBa2vm09bOG1oojOP1vNj8V7+M2AfUkYP1sRQ+xlRm4=
Expand Down
2 changes: 1 addition & 1 deletion internal/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func NewConfluentCommand(cfg *config.Config) *cobra.Command {
cmd.AddCommand(connect.New(cfg, prerunner))
cmd.AddCommand(context.New(prerunner))
cmd.AddCommand(endpoint.New(cfg, prerunner))
cmd.AddCommand(environment.New(prerunner))
cmd.AddCommand(environment.New(cfg, prerunner))
cmd.AddCommand(feedback.New(prerunner))
cmd.AddCommand(flink.New(cfg, prerunner))
cmd.AddCommand(iam.New(cfg, prerunner))
Expand Down
2 changes: 1 addition & 1 deletion internal/connect/command_artifact_create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
return cmd
}

func (c *artifactCommand) createArtifact(cmd *cobra.Command, args []string) error {

Check failure on line 50 in internal/connect/command_artifact_create.go

View check run for this annotation

SonarQube-Confluent / SonarQube Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

[S3776] Cognitive Complexity of functions should not be too high
 See more on https://sonarqube.confluent.io/project/issues?id=cli&pullRequest=3427&issues=17d766c4-53a0-4625-ae42-262d846fa8c9&open=17d766c4-53a0-4625-ae42-262d846fa8c9
displayName := args[0]
artifactFile, err := cmd.Flags().GetString("artifact-file")
if err != nil {
Expand All @@ -61,7 +61,7 @@
if err != nil {
return err
}
if _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
if _, _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
return fmt.Errorf("environment '%s' not found", environment)
}
description, err := cmd.Flags().GetString("description")
Expand Down
2 changes: 1 addition & 1 deletion internal/connect/command_artifact_delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (c *artifactCommand) delete(cmd *cobra.Command, args []string) error {
if err != nil {
return err
}
if _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
if _, _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
return fmt.Errorf("environment '%s' not found", environment)
}

Expand Down
2 changes: 1 addition & 1 deletion internal/connect/command_artifact_describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (c *artifactCommand) describe(cmd *cobra.Command, args []string) error {
if err != nil {
return err
}
if _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
if _, _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
return fmt.Errorf("environment '%s' not found", environment)
}

Expand Down
2 changes: 1 addition & 1 deletion internal/connect/command_artifact_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (c *artifactCommand) list(cmd *cobra.Command, _ []string) error {
if err != nil {
return err
}
if _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
if _, _, err = c.V2Client.GetOrgEnvironment(environment); err != nil {
return fmt.Errorf("environment '%s' not found", environment)
}

Expand Down
52 changes: 41 additions & 11 deletions internal/environment/command.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

57 changes: 24 additions & 33 deletions internal/environment/command_create.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 23 additions & 17 deletions internal/environment/command_delete.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

33 changes: 12 additions & 21 deletions internal/environment/command_describe.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading