Skip to content

Panic fix: exit early if terminal size is 0 #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Steven Gagniere (sgagniere) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Panic fix: exit early if terminal size is 0 #3418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/flink/app/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ func StartApp(gatewayClient ccloudv2.GatewayClientInterface, tokenRefreshFunc fu
utils.OutputErr("Error: failed to initialize console parser")
return errors.NewErrorWithSuggestions("failed to initialize console parser", "Restart your shell session or try another terminal.")
}
if winSize := consoleParser.GetWinSize(); winSize != nil && (winSize.Col == 0 || winSize.Row == 0) {
return errors.NewErrorWithSuggestions("failed to determine terminal size or terminal size is 0", "Check that your terminal window has valid dimensions.")
}
Comment on lines +88 to +90
Comment on lines +88 to +90
appController.AddCleanupFunction(func() {
utils.TearDownConsoleParser(consoleParser)
utils.RestoreStdin(stdinBefore)
Expand Down Expand Up @@ -149,6 +152,9 @@ func StartAppOnPrem(flinkCmfClient *flink.CmfRestClient, tokenRefreshFunc func()
utils.OutputErr("Error: failed to initialize console parser")
return errors.NewErrorWithSuggestions("failed to initialize console parser", "Restart your shell session or try another terminal.")
}
if winSize := consoleParser.GetWinSize(); winSize != nil && (winSize.Col == 0 || winSize.Row == 0) {
return errors.NewErrorWithSuggestions("failed to determine terminal size or terminal size is 0", "Check that your terminal window has valid dimensions.")
}
appController.AddCleanupFunction(func() {
utils.TearDownConsoleParser(consoleParser)
utils.RestoreStdin(stdinBefore)
Expand Down