Increasing coverage and simplifying coverage report creation.#3103
Increasing coverage and simplifying coverage report creation.#3103David Adams (davidadas) wants to merge 2 commits intoconfluentinc:mainfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to increase unit and integration test coverage while simplifying the creation of coverage reports. Key changes include:
- Adding new test cases for Flink CLI error scenarios (empty cloud provider and empty region).
- Updating golden files for error output messages.
- Enhancing tests for login commands and BYOK functionality.
- Modifying the Makefile to improve test execution and coverage data merging.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/flink_test.go | New tests for detecting empty cloud provider and region scenarios |
| test/fixtures/output/flink/region/unset-region.golden | Added golden file for region unset command |
| test/fixtures/output/flink/endpoint/* | New golden files for handling missing cloud provider, region, or empty args |
| internal/login/command_test.go | Added test for suspended organization error handling |
| internal/byok/command_create_test.go | Expanded table-driven testing for GCP metadata and BYOK policy command generation |
| Makefile | Updated targets for unit, integration tests, and coverage data merging |
Comments suppressed due to low confidence (1)
test/flink_test.go:609
- The fixture name specified in TestFlinkEmptyRegion ('flink/region/unset.golden') does not match the actual golden file name ('unset-region.golden'). Please update the fixture name in the test or rename the golden file for consistency.
{args: "flink region unset", fixture: "flink/region/unset.golden", exitCode: 0}
| *.summary | ||
| /*report.xml | ||
| /test.summary | ||
| /*.html | ||
| /test/coverage/**/* |
There was a problem hiding this comment.
We'll want to put this above line 15 because everything below that is managed by automation, which will probably revert this.
There was a problem hiding this comment.
This file looks unused; can we remove it?
There was a problem hiding this comment.
This file also looks unused.
This has no breaking changes or customer facing features.
Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
gotestsumruns both in the Semaphore pipeline and locally..gitignoreto include other coverage artifacts.Blast Radius
The blast radius here is nil. At worst, it will cause unit or integ tests to fail or for the coverage to run improperly.
References
N/A
Test & Review
It is tests, so it has indeed been tested.