Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.netflix.conductor.common.metadata.workflow.WorkflowTask;
import com.netflix.conductor.common.run.tasks.TypedTask;

import com.fasterxml.jackson.annotation.JsonInclude;
import lombok.*;

@Data
Expand Down Expand Up @@ -145,6 +146,14 @@

private WorkflowTask workflowTask;

/**
* Secret values the server resolved for this task at poll time and delivered on the wire only
* (never persisted). Populated when the task's {@code TaskDef.runtimeMetadata} declares secret
* names the host resolves from its secret store (conductor-oss PR #1255). Empty/absent otherwise.
*/
@JsonInclude(JsonInclude.Include.NON_EMPTY)
private Map<String, String> runtimeMetadata;

private String domain;

// id 31 is reserved
Expand Down Expand Up @@ -184,7 +193,7 @@
* {@code TaskDef.runtimeMetadata} — resolved
* at poll time, wire-only, never persisted to task input.
*/
private Map<String, String> runtimeMetadata;

Check failure on line 196 in conductor-client/src/main/java/com/netflix/conductor/common/metadata/tasks/Task.java

View workflow job for this annotation

GitHub Actions / Documentation validation

variable runtimeMetadata is already defined in class Task

Check failure on line 196 in conductor-client/src/main/java/com/netflix/conductor/common/metadata/tasks/Task.java

View workflow job for this annotation

GitHub Actions / Java Client Build

variable runtimeMetadata is already defined in class Task

public void setInputData(Map<String, Object> inputData) {
if (inputData == null) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/*
* Copyright 2025 Conductor Authors.
* <p>
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
* <p>
* http://www.apache.org/licenses/LICENSE-2.0
* <p>
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/
package com.netflix.conductor.common.metadata.tasks;

import java.util.Map;

import org.junit.jupiter.api.Test;

import com.fasterxml.jackson.annotation.JsonAutoDetect;
import com.fasterxml.jackson.annotation.PropertyAccessor;
import com.fasterxml.jackson.databind.ObjectMapper;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;

/**
* The server delivers host-resolved secret values on {@code Task.runtimeMetadata} (wire-only, never
* persisted) when a worker's {@code TaskDef.runtimeMetadata} declares secret names (conductor-oss PR
* #1255). This verifies the client model round-trips the field and omits it when empty.
*/
public class TaskRuntimeMetadataSerDeTest {

private ObjectMapper mapper() {
ObjectMapper m = new ObjectMapper();
m.setVisibility(PropertyAccessor.GETTER, JsonAutoDetect.Visibility.NONE);
m.setVisibility(PropertyAccessor.IS_GETTER, JsonAutoDetect.Visibility.NONE);
m.setVisibility(PropertyAccessor.FIELD, JsonAutoDetect.Visibility.ANY);
return m;
}

@Test
public void runtimeMetadata_roundTrips() throws Exception {
ObjectMapper mapper = mapper();
Task task = new Task();
task.setRuntimeMetadata(Map.of("GITHUB_TOKEN", "ghp_secret", "GH_APP_ID", "42"));

String json = mapper.writeValueAsString(task);
assertTrue(json.contains("\"runtimeMetadata\""), "field must serialize under the wire key");

Task back = mapper.readValue(json, Task.class);
assertEquals("ghp_secret", back.getRuntimeMetadata().get("GITHUB_TOKEN"));
assertEquals("42", back.getRuntimeMetadata().get("GH_APP_ID"));
}

@Test
public void runtimeMetadata_omittedWhenEmpty() throws Exception {
String json = mapper().writeValueAsString(new Task());
assertFalse(json.contains("runtimeMetadata"), "empty/absent map must not appear on the wire");
}
}
Loading