Switch from PrefixRecord to PackageRecord - #1325
Conversation
marcoesters
left a comment
There was a problem hiding this comment.
This PR should be added to the news item.
Technically, this is a hack. PackageRecord and PrefixRecord describe two separate items (an archive file vs an installed package in an environment). Instead of coercing this into PackageRecords, could we just remove the entries we don't need in the dictionary representation/the data dump before we add it into info.json? That way, we stay correct while also removing unnecessary data.
942d42d to
e9d8bce
Compare
|
Good call @marcoesters, see e9d8bce. However regarding the news item, we only modified the existing implementation so I would say it is already covered by https://github.com/conda/constructor/blob/main/news/1314-build-environment-info, or do you disagree? |
Correct. So, the new item should be modified to list both PR numbers, i.e., |
Description
This PR improves the changes added in #1314. It was noticed that
PrefixRecordadded much more metadata than necessary which bloated theinfo.jsonfile. Comparing the twoinfo.json(before/after this implementation) shows about a 70x reduction in file size when usingPackageRecord.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?