Extend support to include win-arm64 - #1323
Conversation
conda-bot
added
the
cla-signed
marcoesters
left a comment
marcoesters
left a comment
There was a problem hiding this comment.
Nice! Just a few details to check.
| def test_supported_platforms_includes_win_arm64(): | ||
| assert "win-arm64" in SUPPORTED_PLATFORMS |
There was a problem hiding this comment.
Aren't you covering that in test_ns_platform? If not, I think this should be a more general test.
|
|
||
|
|
||
| def new_background(size, color, bs=20, boxes=50): | ||
| from PIL import Image, ImageDraw |
There was a problem hiding this comment.
Is there a way we can do this test on a module level?
There was a problem hiding this comment.
Yeah so there are many ways and honestly I dont think any solution looks pretty, but I think the changes I made here 5fce452 now looks "the least cluttered".
| ${EndIf} | ||
| {%- elif win_arm64 %} | ||
| # Make sure we're actually on native ARM64 Windows. | ||
| ${IfNot} ${IsNativeARM64} |
There was a problem hiding this comment.
Can we have a similar check for the MSI installers?
There was a problem hiding this comment.
I did some investigation and couldnt find anything that exists today unfortunately. @freakboy3742 do you know if there is anything to check if an .msi installer is running on the wrong architecture? If not, let me know I'm happy to create a ticket.
3 participants
Description
This PR adds source-level support for
win-arm64(arch parsing, platform registration, etc.) such thatconstructorcan build ARM64 installers when invoked with--platform win-arm64. Does not addwin-arm64to CI — that's tracked separately.New error check - how it looks like running an
.exebuilt on my amd64 pc while running it on arm64 via parallels:Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?