Only include platform-native data files for conda and menuinst#237
Merged
marcoesters merged 4 commits intoconda:mainfrom Jan 29, 2026
Merged
Only include platform-native data files for conda and menuinst#237marcoesters merged 4 commits intoconda:mainfrom
conda and menuinst#237marcoesters merged 4 commits intoconda:mainfrom
Conversation
conda-bot
added
the
cla-signed
lrandersson
reviewed
Jan 29, 2026
| from PyInstaller.utils.hooks import collect_submodules, copy_metadata | ||
|
|
||
|
|
||
| def get_menuinst_datas() -> list[tuple[str, str]]: |
Contributor
There was a problem hiding this comment.
I think this looks good, I just had a few optional cosmetic changes:
get_menuinst_datas->get_menuinst_data- Use
pathlibinstead ofos.path, but since currently have zero use here ofpathlibI'm fine skipping this and replacing this in a separate PR (similar to Use pathlib whenever possible constructor#1063)
Contributor
Author
There was a problem hiding this comment.
I kept what we had before to keep the changes focused. I don't know if pyinstaller can handle Path objects though.
lrandersson
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
conda-standaloneincludes unnecessary data files in the distributed binary. These are:conda.menuinstschemas and launchers (for macOS) only.Only include platform-native files. This removes all batch files and Windows binary files from Unix packages, only uses the schema the packaged
menuinstversion uses, and only ships the launchers that are needed for the target platform.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?