Make the inject function of Unfold pure#3223
Open
harendra-kumar wants to merge 17 commits into
Open
Conversation
Change Unfold's inject from (a -> m s) to (a -> s). Improves fusion, Stream.unfold no longer needs a PreInit state, eliminating one state constructor and one Skip on the first pull for unfolds with a pure inject. Also fixes a latent bug in Unfold.before where `action >> inject` resolved through the Reader (((->) a)) monad's >> and silently dropped the action.
harendra-kumar
force-pushed
the
streaming-updates
branch
from
9d422d3 to
df465ea
Compare
harendra-kumar
force-pushed
the
streaming-updates
branch
from
df465ea to
5166ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, rename some constructors, modules, types in Scans.