Skip to content

Fix tag visibility and second show bugs - #231

Open
bladtcasper-afk wants to merge 3 commits into
compas-dev:mainfrom
bladtcasper-afk:fix_tag_visibility
Open

Fix tag visibility and second show bugs#231
bladtcasper-afk wants to merge 3 commits into
compas-dev:mainfrom
bladtcasper-afk:fix_tag_visibility

Conversation

@bladtcasper-afk

Copy link
Copy Markdown

TagObject bugfixes

  • [x ] Bug fix in a backwards-compatible manner.

Fixed bugs (2):

  • In the viewer, the visibility of a tag could be changed individually, but it would not adhere to group visibility.

  • If viewer.show() would be called twice in a script, the tags would not be shown the second time with the following error:
    'TagObject' object has no attribute 'text_aspect'

text_aspect is only assigned within TagObject.init() which is only initialised with Renderer.init() on the first viewer.show()

Checklist

  • [x ] I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I have added tests that prove my fix is effective or that my feature works.
    It is a small fix. I have changed the tag.py example file. This file will give an error using the current main compas_viewer, but will be fixed by the suggested update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant