Fix tag visibility and second show bugs - #231
Open
bladtcasper-afk wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TagObject bugfixes
Fixed bugs (2):
In the viewer, the visibility of a tag could be changed individually, but it would not adhere to group visibility.
If viewer.show() would be called twice in a script, the tags would not be shown the second time with the following error:
'TagObject' object has no attribute 'text_aspect'
text_aspect is only assigned within TagObject.init() which is only initialised with Renderer.init() on the first viewer.show()
Checklist
CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).It is a small fix. I have changed the tag.py example file. This file will give an error using the current main compas_viewer, but will be fixed by the suggested update.