Skip to content

feat: add advanced settings application hook #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukdz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add advanced settings application hook #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/ui.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ saved default no longer matches what the script wants.

`advanced_settings` — one function, the full interactive configuration path.

Application scripts may optionally define `advanced_settings_app_configure` and
`advanced_settings_app_summary`. The first runs before the confirmation dialog
in the Advanced wizard; the second returns a text block appended to that
dialog. This keeps application-specific settings in the script without
replacing or parsing the shared wizard. Both callbacks are optional and are
never called by default or silent installs.

## [`menu.func`](../ui/menu.func)

The entry points and the menus:
Expand Down
15 changes: 15 additions & 0 deletions ui/advanced.func
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,13 @@ Leave empty to skip."
else
_verbose="no"
fi

# Applications may add their own advanced settings without replacing this
# wizard. The optional callbacks are defined by the application script.
if declare -f advanced_settings_app_configure >/dev/null 2>&1; then
advanced_settings_app_configure
fi

# Build summary
local ct_type_desc="Unprivileged"
[[ "$_ct_type" == "0" ]] && ct_type_desc="Privileged"
Expand Down Expand Up @@ -1150,6 +1157,14 @@ Advanced:
Verbose: $_verbose
Post-Install Script: ${post_install_display}${post_install_warn}"

if declare -f advanced_settings_app_summary >/dev/null 2>&1; then
local app_summary
app_summary="$(advanced_settings_app_summary)"
[[ -n "$app_summary" ]] && summary="${summary}

${app_summary}"
fi

if whiptail --backtitle "Proxmox VE Helper Scripts [Step $STEP/$MAX_STEP]" \
--title "CONFIRM SETTINGS" \
--ok-button "Create LXC" --cancel-button "Back" \
Expand Down
Loading