ci: write the job summary from one matrix leg, not three - #255
Merged
Conversation
Every leg checks the same commits against the same rules, so all three produce a byte-identical report and the run page carries three copies of it. The matrix is here to prove the action runs on ubuntu, macos and windows — not to say the same thing three times. pr-comments was already guarded this way two lines below; this is the same guard on the surface that was still missing it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe commit-check workflow now enables ChangesCI job summary
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The run page currently shows three summaries:
All three are byte-identical. Every leg checks the same commits against the
same rules, so the report cannot differ between them — the matrix is here to
prove the action runs on each OS, not to say the same thing three times.
pr-commentswas already guarded exactly this way two lines below, to stopthe same duplication on the comment surface. This applies the same guard to
the surface that was still missing it:
The other two legs still run every check and still fail the job on a
violation — they just stop writing a duplicate report.
Why not rename it to plain
commit-check summaryThat heading text is generated by GitHub from the job name, and a matrix
job's name is
<job-id> (<matrix values>). Getting the suffix off it meanssplitting this into a reporting job plus a separate cross-platform job, which
changes the check names and would need any required-status-check settings on
mainupdated to match. Not worth it for the suffix; out of scope here.Generated by Claude Code
Summary by CodeRabbit