fix: stop rejecting Renovate branches in the org config - #45
Merged
Conversation
allow_branch_types restated commit-check's default list, which froze it. Two prefixes had since dropped out of the copy: dependabot/ and renovate/. dependabot survives because it is also in ignore_authors; Renovate is not, so its branches fail a check they have no way to satisfy. Removing the override hands the list back to commit-check, which keeps it a superset of the Conventional Branch spec. Verified against the version the action pins today (2.12.2): renovate/ and dependabot/ now pass. The types added upstream since — docs/, ci/, test/, refactor/ — start passing once a release carrying them lands, without another edit here.
Commit-Check ✔️ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe branch configuration removes the explicit ChangesBranch configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow_branch_types restated commit-check's default list, which froze it. Two prefixes had since dropped out of the copy: dependabot/ and renovate/. dependabot survives because it is also in ignore_authors; Renovate is not, so its branches fail a check they have no way to satisfy.
Removing the override hands the list back to commit-check, which keeps it a superset of the Conventional Branch spec. Verified against the version the action pins today (2.12.2): renovate/ and dependabot/ now pass. The types added upstream since — docs/, ci/, test/, refactor/ — start passing once a release carrying them lands, without another edit here.
Summary by CodeRabbit