Skip to content

Add email field in address form component#1048

Open
pfferrari wants to merge 2 commits intomainfrom
email-in-address-form
Open

Add email field in address form component#1048
pfferrari wants to merge 2 commits intomainfrom
email-in-address-form

Conversation

@pfferrari
Copy link
Contributor

@pfferrari pfferrari commented Mar 10, 2026

Related commercelayer/issues-app/issues/558

What I did

Added email field in ResourceAddressFormFields component to enable also email editability.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@netlify
Copy link

netlify bot commented Mar 10, 2026

Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit 524d2ef
🔍 Latest deploy log https://app.netlify.com/projects/commercelayer-app-elements/deploys/69b3f7a377d3710008aeaa8b
😎 Deploy Preview https://deploy-preview-1048--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pfferrari pfferrari self-assigned this Mar 10, 2026
@pfferrari pfferrari added the enhancement New feature or request label Mar 10, 2026
@pfferrari pfferrari changed the title Add email in address form fields Add email field in address form component Mar 10, 2026
@pfferrari
Copy link
Contributor Author

@malessani @gciotola @marcomontalbano do you see any issue in always showing the email field in address forms? Do you think we need a prop in ResourceAddress to conditionally show and edit the email? Or do we can go for it without concerns?

@malessani
Copy link
Contributor

I think the email attribute on the address resource is something that needs to be shown based on the context. For example on the order, we don't need it, because it is on the customer, while for other entity where the email is not there, could be interesting to show the attribute.

@pfferrari pfferrari marked this pull request as draft March 10, 2026 15:04
@pfferrari
Copy link
Contributor Author

pfferrari commented Mar 10, 2026

Ok, it makes sense also for me.. I'll go for adding any needed prop to match this behavior..

@pfferrari pfferrari marked this pull request as ready for review March 11, 2026 10:15
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 11, 2026

npm i https://pkg.pr.new/commercelayer/app-elements/@commercelayer/app-elements@1048

commit: 524d2ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants