Open
Conversation
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
email in address form fieldsemail field in address form component
Contributor
Author
|
@malessani @gciotola @marcomontalbano do you see any issue in always showing the |
Contributor
|
I think the email attribute on the address resource is something that needs to be shown based on the context. For example on the order, we don't need it, because it is on the customer, while for other entity where the email is not there, could be interesting to show the attribute. |
Contributor
Author
|
Ok, it makes sense also for me.. I'll go for adding any needed prop to match this behavior.. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related commercelayer/issues-app/issues/558
What I did
Added
emailfield inResourceAddressFormFieldscomponent to enable also email editability.Checklist