Skip to content

messaging: integrate msgq runtime logger API#37510

Closed
adeebshihadeh wants to merge 2 commits intomasterfrom
msgq_real_logger
Closed

messaging: integrate msgq runtime logger API#37510
adeebshihadeh wants to merge 2 commits intomasterfrom
msgq_real_logger

Conversation

@adeebshihadeh
Copy link
Copy Markdown
Contributor

Summary

  • consume msgq runtime logger API from logger: replace SWAGLOG include hack with runtime logger API msgq#679
  • remove the SWAGLOG compile-time include override for msgq_repo in SConstruct
  • register msgq C++ logs to cloudlog via common/swaglog.cc using a weak msgq_set_logger hook
  • register msgq Python logs in cereal.messaging via msgq.set_logger()
  • fix static-link ordering for targets that link both visionipc and msgq symbols

Validation

  • scons -j8 msgq_repo/msgq/ipc_pyx.so msgq_repo/msgq/visionipc/visionipc_pyx.so system/loggerd/encoderd tools/replay/replay
  • PYTHONPATH=. python - <<'PY' ... import cereal.messaging; VisionIpcServer/VisionIpcClient connect smoke test ... PY
  • PYTHONPATH=. pytest -q cereal/messaging/tests/test_pub_sub_master.py

@adeebshihadeh adeebshihadeh deleted the msgq_real_logger branch March 1, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant