v2.1.6#46
Merged
Merged
Conversation
…to module config
handle null value
… events When showJavaStackTrace=true, the Java stack trace is now parsed into structured Sentry exception values with proper frames (function, filename, lineno, in_app) instead of being dumped as a raw text blob in 'extra'. This gives Sentry proper structured frames for the Java side of the call stack, enabling: - Frame-by-frame navigation in the Sentry UI - Proper exception chaining via 'Caused by:' parsing - Correct grouping and deduplication - in_app heuristics for application vs framework frames The parseJavaStackTrace() method handles: - Standard 'at package.Class.method(File.java:line)' frames - 'Native Method' and 'Unknown Source' frames (no line number) - 'Caused by:' nested exception chains - '... N more' truncated frame indicators Also includes: - Null-safety fix for structifyObject() (from inleague-api patch) - Deprecation of removeTabsOnJavaStackTrace parameter - 7 new test cases covering parsing, in_app detection, Caused by chains, empty TagContext fallback, and edge cases
- Add \r stripping before splitting by \n (regression from old code) - Add jakarta. to in_app exclusion list (Jakarta EE classes) - Add Suppressed: exception handling (Java 7+ suppressed exceptions) - These fix medium-priority issues from code review
… of regex BoxLang's regex engine doesn't handle non-greedy quantifiers and complex patterns reliably. Rewrote parseJavaStackTrace() to use find(), mid(), left() and simple string operations for parsing. This fixes all 5 test failures: - Exception type was including the message (regex not splitting on colon) - Frames array was empty (at-pattern regex not matching) - Caused by chains only producing 2 exceptions instead of 3 - Suppressed exceptions not being parsed Also fixes the upstream test failures caused by BoxLang incompatibility with the old regex-based approach.
BoxLang's reFindNoCase doesn't handle complex regex patterns reliably. Replaced with simple left() prefix checks against a list of framework packages. More readable and guaranteed to work across engines.
1. 'can log Java exception': Use null-safe operator for e.message which is null when catching Java exceptions on both BoxLang and Lucee 2. 'can log exception with no tagContext': Replace 'for (var key in e)' iteration with duplicate()+structDelete() which works on all engines. BoxLang exceptions don't support key iteration like Lucee/ACF.
1. Make prefix checks include the colon: 'Caused by:' and 'Suppressed:' instead of 'Caused by' and 'Suppressed' 2. Simplify last-dot iteration with listToArray/arrayToList instead of manual character loop 3. Fix indentation after removing the if(lastDot>1) block
1. Gate Java stack trace parsing on TagContext being empty — no need for the overhead when CFML frames are already available 2. Extract duplicated 'Caused by:'/'Suppressed:' parsing into _parseExceptionPrefix() helper function 3. Add test verifying Java traces are skipped when TagContext is present 4. Add .gitignore entries for local server test configs
1. Adobe CF requires 3 parameters for mid() — the 2-parameter form (mid(str, start)) is not supported. Added length parameter to all mid() calls in parseJavaStackTrace() and _parseExceptionPrefix(). 2. Fix 'can log exception with no tagContext' test — duplicate(e) fails on Adobe CF because exception objects are Java-backed. Build the struct manually with known keys instead. Both fixes are engine-agnostic and pass on BoxLang 1.15, Lucee 5, and Adobe CF 2021.
…n-values Feature/java stacktrace exception values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.