Skip to content

Add support for dependencies that aren't package names#724

Merged
cottsay merged 1 commit intomasterfrom
cottsay/dependency-package-names
Mar 24, 2026
Merged

Add support for dependencies that aren't package names#724
cottsay merged 1 commit intomasterfrom
cottsay/dependency-package-names

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented Feb 23, 2026

To date, all dependencies throughout the colcon codebase are always identified by package name, which aligns with the fact that all job identifiers are also package names. To support scenarios where there are jobs which aren't identified by package names, we'll also need to specify dependencies which aren't package names.

To eventually support this scenario, all primary shells (which implement command_prefix templates) should make a similar change to support the new attribute on the DependencyDescriptor class.

Note that at present, dependencies may also be bare strings, though DependencyDescriptor instances are preferred.

To date, all dependencies throughout the colcon codebase are always
identified by package name, which aligns with the fact that all job
identifiers are also package names. To support scenarios where there are
jobs which aren't identified by package names, we'll also need to
specify dependencies which aren't package names.

To eventually support this scenario, all primary shells (which implement
command_prefix templates) should make a similar change to support the
new attribute on the DependencyDescriptor class.

Note that at present, dependencies may also be bare strings, though
DependencyDescriptor instances are preferred.
@cottsay cottsay self-assigned this Feb 23, 2026
@cottsay cottsay added the enhancement New feature or request label Feb 23, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.00%. Comparing base (d03fa25) to head (89c0a3b).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
colcon_core/dependency_descriptor.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #724   +/-   ##
=======================================
  Coverage   86.99%   87.00%           
=======================================
  Files          69       69           
  Lines        4091     4100    +9     
  Branches      707      707           
=======================================
+ Hits         3559     3567    +8     
- Misses        421      422    +1     
  Partials      111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cottsay cottsay requested a review from Blast545 February 25, 2026 03:43
Copy link
Copy Markdown

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarification comments

Comment thread colcon_core/dependency_descriptor.py
Comment thread colcon_core/dependency_descriptor.py
@cottsay cottsay added this to the 0.20.2 milestone Mar 4, 2026
Copy link
Copy Markdown

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed answers to my comments, LGTM

@cottsay cottsay merged commit b5c82cc into master Mar 24, 2026
46 checks passed
@cottsay cottsay deleted the cottsay/dependency-package-names branch March 24, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants