Add support for dependencies that aren't package names#724
Merged
Conversation
To date, all dependencies throughout the colcon codebase are always identified by package name, which aligns with the fact that all job identifiers are also package names. To support scenarios where there are jobs which aren't identified by package names, we'll also need to specify dependencies which aren't package names. To eventually support this scenario, all primary shells (which implement command_prefix templates) should make a similar change to support the new attribute on the DependencyDescriptor class. Note that at present, dependencies may also be bare strings, though DependencyDescriptor instances are preferred.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 86.99% 87.00%
=======================================
Files 69 69
Lines 4091 4100 +9
Branches 707 707
=======================================
+ Hits 3559 3567 +8
- Misses 421 422 +1
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Blast545
reviewed
Mar 2, 2026
Blast545
approved these changes
Mar 6, 2026
Blast545
left a comment
There was a problem hiding this comment.
Thanks for the detailed answers to my comments, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To date, all dependencies throughout the colcon codebase are always identified by package name, which aligns with the fact that all job identifiers are also package names. To support scenarios where there are jobs which aren't identified by package names, we'll also need to specify dependencies which aren't package names.
To eventually support this scenario, all primary shells (which implement command_prefix templates) should make a similar change to support the new attribute on the DependencyDescriptor class.
Note that at present, dependencies may also be bare strings, though DependencyDescriptor instances are preferred.