Rework Package identification tests

[rotu]

Package identifications test was doing way too much in one test to follow.
Split into multiple, more targeted tests and added some additional coverage

[codecov-io]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.32%. Comparing base (165c033) to head (04713ee).
⚠️ Report is 237 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   79.50%   79.32%   -0.19%     
==========================================
  Files          55       55              
  Lines        3221     3221              
  Branches      535      535              
==========================================
- Hits         2561     2555       -6     
- Misses        613      617       +4     
- Partials       47       49       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dirk-thomas]

In the current state the patch reduced test coverage in some part of the code.

[dirk-thomas]

@rotu Friendly ping.

[rotu]

Thanks for the ping.
The coverage dip is due to the xfail on test_re_identify_python_if_different_python_package. That's the downside of breaking this up into two PRs.

[rotu]

@dirk-thomas Friendly ping.

[dirk-thomas]

Thanks for improving the tests.

I will just wait for clicking merge until #215 is good to be merged (to avoid the temporary drop of coverage between them).

[dirk-thomas]

Please rebase / resolve conflict to be able to re-review and merge this patch.

[dirk-thomas]

@rotu Please rebase this branch in a way that the pull requests only shows commits related to this change.

[rotu]

@rotu Please rebase this branch in a way that the pull requests only shows commits related to this change.

Oops. Nothing like rebasing on the wrong master. Blech. Let me try one more time...

Success!