Skip to content

fix(telemetry-dashboard): accept Origin: null on login — no-referrer policy locked Chromium out (CG-16) #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colbymchenry wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

fix(telemetry-dashboard): accept Origin: null on login — no-referrer policy locked Chromium out (CG-16) #1498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions telemetry-dashboard/scripts/smoke-auth.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,14 @@ check "cross-origin post → 400" 400 \
"$(status -X POST "$BASE/login" -H 'Origin: https://evil.example' -d "password=${PASSWORD}")"
# One sign-in, then every cookie assertion reads the captured headers. Doing a
# fresh POST per assertion would burn the login rate limit and 429 halfway down.
SIGNIN="$(curl -s -D - -o /dev/null -c "$JAR" -X POST "$BASE/login" -d "password=${PASSWORD}" -d "next=/")"
check "correct password → 302" "302" "$(printf '%s' "$SIGNIN" | head -1 | awk '{print $2}')"
# The sign-in carries `Origin: null` — what Chromium actually sends on a
# same-origin form submit from a page with our `Referrer-Policy: no-referrer`
# header. Rejecting it locked every Chromium browser out of the login form
# while curl-shaped tests (no Origin at all) kept passing.
SIGNIN="$(curl -s -D - -o /dev/null -c "$JAR" -X POST "$BASE/login" -H 'Origin: null' -d "password=${PASSWORD}" -d "next=/")"
SIGNIN_STATUS="$(printf '%s' "$SIGNIN" | head -1 | awk '{print $2}')"
check "correct password → 302" "302" "$SIGNIN_STATUS"
check "Origin: null (Chromium form post) not rejected" "yes" "$([ "$SIGNIN_STATUS" != "400" ] && echo yes || echo no)"
contains "cookie is HttpOnly" "HttpOnly" "$SIGNIN"
contains "cookie is Secure" "Secure" "$SIGNIN"
contains "cookie is SameSite=Lax" "SameSite=Lax" "$SIGNIN"
Expand Down Expand Up @@ -173,10 +179,12 @@ check "tampered cookie on a page → 302 to login" 302 \

echo
echo "Sign-out"
check "POST /logout → 302" 302 "$(status -X POST "$BASE/logout")"
check "POST /logout → 302" 302 "$(status -X POST "$BASE/logout" -H 'Origin: null')"
contains "logout clears the cookie" "Max-Age=0" \
"$(curl -s -D - -o /dev/null -X POST "$BASE/logout")"
check "GET /logout → 405" 405 "$(status "$BASE/logout")"
check "cross-origin logout → 400" 400 \
"$(status -X POST "$BASE/logout" -H 'Origin: https://evil.example')"

echo
echo "Rate limiting (6 attempts in a minute; the 6th should be capped)"
Expand Down
Binary file modified telemetry-dashboard/src/auth.ts
View file
Open in desktop
Binary file not shown.