fix(SyntheticTimeSeries): synthetic time series query fails when variable contains certain characters - #2766
Draft
MortGron wants to merge 1 commit into
Draft
fix(SyntheticTimeSeries): synthetic time series query fails when variable contains certain characters#2766MortGron wants to merge 1 commit into
MortGron wants to merge 1 commit into
Conversation
…able contains dash
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2766 +/- ##
==========================================
+ Coverage 93.77% 93.82% +0.04%
==========================================
Files 513 513
Lines 52445 52620 +175
==========================================
+ Hits 49181 49369 +188
+ Misses 3264 3251 -13
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By mistake, synthetic time series queries will fail when
re.escape(var) != varfor some variablevarin a query expression before variable replacement. However, they do not fail when variables contain characters like\.Even though this fixes a bug, a long term solution to make variable names safer is #2762
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.