fix(records): point at as_id() when delete receives records - #2750
Draft
andersfylling wants to merge 2 commits into
Draft
fix(records): point at as_id() when delete receives records#2750andersfylling wants to merge 2 commits into
andersfylling wants to merge 2 commits into
Conversation
…bute Handing delete() the records you just fetched is a plausible mistake, and the resulting "AttributeError: Record object has no attribute as_dict" points at SDK internals rather than at as_id()/as_ids(). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
RecordIdSequence.load now checks what it was handed and raises TypeError naming RecordId and the as_id()/as_ids() conversions, instead of letting a Record, a dict or a plain string reach as_dict() and fail as an AttributeError. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handing
delete()the records you just fetched is a plausible mistake, and the error points at SDK internals instead of at the conversion you need:RecordIdSequence.loadnow checks what it was given and raises TypeError namingRecordIdand theas_id()/as_ids()conversions. Same for a list of dicts or a bare external-id string.First commit is the failing tests, second is the fix.
🤖 Generated with Claude Code