Skip to content

feat: ExchangePolicy in API#187

Merged
jsnctl merged 5 commits intomainfrom
jsnctl/exchange-policy
Mar 19, 2026
Merged

feat: ExchangePolicy in API#187
jsnctl merged 5 commits intomainfrom
jsnctl/exchange-policy

Conversation

@jsnctl
Copy link
Copy Markdown
Contributor

@jsnctl jsnctl commented Mar 18, 2026

No description provided.

@jsnctl jsnctl self-assigned this Mar 18, 2026
@jsnctl jsnctl added this to the now milestone Mar 18, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2026

The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 19, 2026, 10:48 AM

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the ExchangePolicyService to the API, enabling the management of exchange policies. It includes protobuf definitions for the service and its messages, gRPC stubs, and Connect implementations, providing a comprehensive framework for interacting with exchange policies.

Highlights

  • New Service Definition: Introduces the ExchangePolicyService in the API, defining gRPC methods for managing exchange policies.
  • Message Definitions: Adds protobuf message definitions for requests and responses related to creating, destroying, getting, listing, and updating exchange policies.
  • gRPC Implementation: Generates gRPC service stubs and client interfaces for the ExchangePolicyService.
  • Connect Implementation: Adds Connect-specific code for the ExchangePolicyService, including client and handler implementations.
  • Exchange Policy Model: Defines the ExchangePolicy protobuf message, including fields for matching conditions and outbound scopes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ExchangePolicy service, including protobuf definitions, gRPC service definitions, and connect implementation. It defines messages for creating, destroying, getting, listing, and updating exchange policies, along with corresponding service methods. Additionally, it includes code generation for Go, gRPC, and TypeScript.

Comment thread gen/go/proto/exchange_policy/v1alpha1/exchange_policy.pb.go
Comment thread proto/exchange_policy/v1alpha1/exchange_policy.proto Outdated
Comment thread proto/exchange_policy/v1alpha1/exchange_policy.proto
Comment thread proto/exchange_policy/v1alpha1/exchange_policy.proto Outdated
@jsnctl jsnctl requested a review from markgoddard March 19, 2026 10:02
@jsnctl jsnctl enabled auto-merge (squash) March 19, 2026 10:02
Copy link
Copy Markdown
Member

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jsnctl jsnctl merged commit 9af2308 into main Mar 19, 2026
5 checks passed
@jsnctl jsnctl deleted the jsnctl/exchange-policy branch March 19, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants