YARD fixes + UserSortable concern - #2120
Open
Oaphi wants to merge 6 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
It confuses the heck out of YARD + aligns it with other model concerns + removed the need to disable the "1 class per file" rule of Rubocop
Oaphi
changed the title
cellio
reviewed
Jul 31, 2026
Member
There was a problem hiding this comment.
Don't rely just on me, but this looks good to me. That weird "align=center" thing on the landing page was there before too; I don't know what's causing it, but it's not a regression.
I reviewed only the doc, not the part where you moved UserSortable into a concern.
ArtOfCode-
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional manual testing requested: sorting of logs and posts (just that it still works as expected)