feat: add command to restart GCP VMs and implement related functionality#281
Draft
OliverTrautvetter wants to merge 9 commits intomainfrom
Draft
feat: add command to restart GCP VMs and implement related functionality#281OliverTrautvetter wants to merge 9 commits intomainfrom
OliverTrautvetter wants to merge 9 commits intomainfrom
Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an oms beta bootstrap-gcp restart-vms command and the underlying GCP bootstrapper functionality to start stopped/terminated Compute Engine instances defined by the existing vmDefs inventory.
Changes:
- Add
RestartVM/RestartVMsto the GCP bootstrapper for starting stopped/terminated instances and waiting for readiness. - Introduce a new Cobra subcommand
beta bootstrap-gcp restart-vmsplus generated docs. - Update NOTICE files for dependency version bumps.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| NOTICE | Updates recorded dependency versions/URLs (google.golang.org/api, google.golang.org/grpc). |
| internal/tmpl/NOTICE | Mirrors NOTICE dependency version/URL updates in the template. |
| internal/bootstrap/gcp/gce.go | Adds VM restart helpers and methods (RestartVM, RestartVMs). |
| internal/bootstrap/gcp/gce_test.go | Adds unit tests for the new restart methods. |
| docs/oms_beta_bootstrap-gcp.md | Adds the new restart-vms command to the command list. |
| docs/oms_beta_bootstrap-gcp_restart-vms.md | Adds generated docs for the new command. |
| cli/cmd/bootstrap_gcp.go | Wires the new restart-vms subcommand into bootstrap-gcp. |
| cli/cmd/bootstrap_gcp_restart_vms.go | Implements the new Cobra command and its flag/infra-file handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ts for RestartVMs
…into restart_vm
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… BootstrapGcpRestartVMsCmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a way to restart VMs that have been stopped.
Clickup