Fix missing CSS highlighting in CodeMirror editor#8863
Open
karlhorky wants to merge 1 commit intocodesandbox:mainfrom
Open
Fix missing CSS highlighting in CodeMirror editor#8863karlhorky wants to merge 1 commit intocodesandbox:mainfrom
karlhorky wants to merge 1 commit intocodesandbox:mainfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
Pull request overview
This PR fixes missing CSS syntax highlighting in the CodeMirror editor by adding the required CSS mode import to the CodeMirror utilities module.
Changes:
- Added CSS mode import to ensure CSS syntax highlighting works in all CodeMirror instances
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: Fix the missing CSS syntax highlighting in the CodeMirror editor (all CSS code remains dark gray on the left side):
There is also no tokenization of the CSS syntax:
https://codesandbox.io/embed/mdgh4k?codemirror=1&fontsize=12&module=index.css&module=index.html&view=split
What is the current behavior?
CSS syntax highlighting missing (see above)
What is the new behavior?
CSS syntax highlighting not missing (hopefully)
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist
cc @CompuIves here's the PR we talked about offline