refactor: drop MetricsConfig from ToolchainStatus type

[xcoulon]

metrics are not stored in the ToolchainStatus anymore
also, no need to keep the MetricsConfig in the ToolchainConfig anymore,
since host-operator metrics are always recounted from the resources during startup.
(ForceSynchronization was always true)

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Summary by CodeRabbit

• Chores

  • Removed metrics tracking/configuration and related status entries from the API.
  • Removed per-member space count and the "MURs" status column previously shown in listings.
  • Cleaned up generated helpers and public API schema to reflect these removals.

• Documentation

  • Trimmed API reference to remove metrics-related sections and added a note that the masterUserRecord field is immutable.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 25867968-606a-43dc-8ab7-21c2f83cca74

📥 Commits

Reviewing files that changed from the base of the PR and between f4024c6 and a6c5b4a.

📒 Files selected for processing (4)

• api/v1alpha1/docs/apiref.adoc
• api/v1alpha1/toolchainconfig_types.go
• api/v1alpha1/zz_generated.deepcopy.go
• api/v1alpha1/zz_generated.openapi.go

💤 Files with no reviewable changes (3)

• api/v1alpha1/toolchainconfig_types.go
• api/v1alpha1/zz_generated.deepcopy.go
• api/v1alpha1/docs/apiref.adoc

---

Walkthrough

Removed metrics-related API types, fields, constants, and associated generated code across the api/v1alpha1 package, and deleted the Member.SpaceCount field; corresponding OpenAPI schema entries and documentation blocks were also removed.

Changes

Cohort / File(s)	Summary
API type changes api/v1alpha1/toolchainconfig_types.go, api/v1alpha1/toolchainstatus_types.go	Removed MetricsConfig type and HostConfig.Metrics field; removed Metric alias, ToolchainStatusStatus.Metrics field, Member.SpaceCount field, and two Prometheus metric key constants; removed kubebuilder printcolumn for MURs.
Generated deepcopy api/v1alpha1/zz_generated.deepcopy.go	Deleted DeepCopy/DeepCopyInto methods for Metric and MetricsConfig; removed metrics-related deep-copy logic from HostConfig.DeepCopyInto and ToolchainStatusStatus.DeepCopyInto.
Generated OpenAPI api/v1alpha1/zz_generated.openapi.go	Removed OpenAPI definition function and registry entry for MetricsConfig; removed metrics property from ToolchainStatusStatus schema and spaceCount from Member schema; updated dependency lists to drop MetricsConfig.
Documentation api/v1alpha1/docs/apiref.adoc	Removed metrics-related documentation sections and references (Metric, MetricsConfig, metrics fields); added a note marking binding.masterUserRecord as immutable via validating webhook.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description lacks required sections from the template (Checks checklist with yes/no answers and PR links for dependent projects).	Add the Checks section with answers to all checklist items and provide PR links for host-operator and member-operator if changes were made in those projects.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: removing MetricsConfig from ToolchainStatus and related types.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[MatousJobanek]

Looks like a forgotten legacy zombie, but this line can be removed too:

api/api/v1alpha1/toolchainstatus_types.go

Line 274 in 912fcbd

// +kubebuilder:printcolumn:name="MURs",type="integer",JSONPath=`.status.hostOperator.masterUserRecordCount`

[xcoulon]

Looks like a forgotten legacy zombie, but this line can be removed too:

api/api/v1alpha1/toolchainstatus_types.go

Line 274 in 912fcbd

// +kubebuilder:printcolumn:name="MURs",type="integer",JSONPath=`.status.hostOperator.masterUserRecordCount`

good catch! removed in f4024c6

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud