refactor: fix blind exceptions and clean up stale linter ignores#582
Open
bijanmurmu wants to merge 1 commit into
Open
refactor: fix blind exceptions and clean up stale linter ignores#582bijanmurmu wants to merge 1 commit into
bijanmurmu wants to merge 1 commit into
Conversation
This commit addresses the stale TODO in pyproject.toml by removing the ignore rules for BLE001, S108, and FAST003. All 11 instances of broad exception catching (except Exception:) across the codebase have been either replaced with specific exceptions (e.g. ValueError, OSError, InvalidNotebookError, httpx.RequestError) or annotated with # noqa: BLE001 where a global catch-all is explicitly required by design (e.g., global error handlers and cache fallbacks). Additional minor linter warnings (FURB171 and ASYNC240) were also addressed to ensure a fully passing codebase. Fixes coderamp-labs#581.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses the stale TODO in pyproject.toml by removing the ignore rules for BLE001, S108, and FAST003. All 11 instances of broad exception catching (except Exception:) across the codebase have been either replaced with specific exceptions (e.g. ValueError, OSError, InvalidNotebookError, httpx.RequestError) or annotated with # noqa: BLE001 where a global catch-all is explicitly required by design (e.g., global error handlers and cache fallbacks). Additional minor linter warnings (FURB171 and ASYNC240) were also addressed to ensure a fully passing codebase. Fixes #581.