feat(vscode-desktop-core): support extension pre-installation#955
Open
Edd88-pixel wants to merge 1 commit into
Open
feat(vscode-desktop-core): support extension pre-installation#955Edd88-pixel wants to merge 1 commit into
Edd88-pixel wants to merge 1 commit into
Conversation
Contributor
Author
|
This Core change needs to be merged and released before the follow-up Windsurf PR can be submitted. The Windsurf module must depend on a published vscode-desktop-core 1.2.0; submitting it earlier would leave the Registry dependency unresolved and prevent Terraform initialization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
VS Code-based IDE wrappers currently have no shared way to pre-install remote extensions before the first desktop connection. Each wrapper would otherwise need to duplicate startup orchestration, path handling, login blocking, and failure behavior.
This adds the reusable primitive needed by Windsurf in #425 while keeping IDE-specific server discovery and bootstrap logic in the wrapper that owns those details. The Core change is intentionally submitted first so wrapper modules can depend on a published
vscode-desktop-core1.2.0 instead of an unreleased interface.Changes
Description
Adds reusable remote extension pre-installation support to
vscode-desktop-core. IDE wrappers provide their verified remote server CLI and storage paths; the Core owns the common finite, login-blocking installation flow.Type of Change
Module Information
Path:
registry/coder/modules/vscode-desktop-coreNew version:
v1.2.0Breaking change: [ ] Yes [x] No
Validation
scripts/terraform_validate.sh— passed forvscode-desktop-core.scripts/terraform_test_all.sh— Core tests passed: 3 passed, 0 failed.scripts/ts_test_auto.sh— 21 passed, 0 failed.bun run fmtandbun run fmt:ci— passed; no unrelated formatting changes.terraform fmt -check -recursiveandgit diff --check— passed.scripts/validate_set_u_order.sh— passed.esbenp.prettier-vscode@12.4.0; after a workspace restart, the server and extension were reused from the persistent home volume and the first client connection recognized Prettier without manual installation.Testing & Validation
bun test)bun fmt)Related Issues
Related to #425. The Windsurf wrapper change will follow after Core 1.2.0 is published.