fix(registry/coder/modules): write bootstrap scripts to module dir instead of /tmp#771
Draft
fix(registry/coder/modules): write bootstrap scripts to module dir instead of /tmp#771
Conversation
…stead of /tmp Bootstrap scripts used fixed /tmp paths with generic names like /tmp/main.sh, making them easy to collide with or accidentally overwrite. Write them into $HOME/<module_dir_name>/scripts/ instead, following the pattern used by the agent-helper module. Also fix install.sh hardcoding port 3284 instead of using ARG_AGENTAPI_PORT. Refs #736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap scripts used fixed /tmp paths with generic names like
/tmp/main.sh, making them easy to collide with or accidentally
overwrite. Write them into $HOME/<module_dir_name>/scripts/ instead,
following the pattern used by the agent-helper module.
Also fix install.sh hardcoding port 3284 instead of using
ARG_AGENTAPI_PORT.
Refs #736