🤖 feat: add prompt history sidebar#3429
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3eaf690a9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3eaf690 to
2dbe55d
Compare
|
@codex review Addressed the stale draft attachment/review feedback: prompt history insertion now sends explicit empty file/review arrays for text-only entries, and the replace handler treats file/review payload presence as a full draft replacement even when those arrays are empty. Added a focused payload test and re-ran |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dbe55d34e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds a right sidebar History tab that lists transcript user prompts oldest-to-newest, lets users jump back to the original message, copy the prompt, or insert it into the composer. Links coder#3416. --- _Generated with `mux` • Model: `GPT-5` • Thinking: `unknown` • Cost: ``_ <!-- mux-attribution: model=GPT-5 thinking=unknown costs=unknown -->
2dbe55d to
095997c
Compare
|
@codex review Addressed the empty review override follow-up: text-only history inserts still clear existing attached reviews, but the empty draft-review override now releases when new reviews are attached later so the Code Review workflow remains visible and sendable. Re-ran the prompt-history tests and |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Adds a right-sidebar History tab for the current transcript. The tab lists real user prompts from oldest to newest and provides quick actions to jump back to the original transcript row, copy the prompt, or insert it into the composer.
Background
Part of #3416. Supersedes closed PR #3421, which GitHub would not reopen after its head branch was force-pushed/recreated. This replacement uses the restored single-feature commit and includes the Codex attachment-preservation fix from #3421.
Implementation
historyright-sidebar tab and label.ChatPaneto reveal a transcript message without reaching across layout boundaries with DOM queries.UPDATE_CHAT_INPUTevent to insert selected history text and attachments into the composer.Validation
/Users/zhak/.npm/_npx/bb6645c1041000be/node_modules/.bin/bun test src/browser/features/RightSidebar/PromptHistoryTab.test.ts/Users/zhak/.npm/_npx/bb6645c1041000be/node_modules/.bin/bun -e 'import { getPromptHistoryEntries } from "./src/browser/features/RightSidebar/promptHistoryEntries.ts"; const fileParts=[{url:"data:text/plain;base64,SGVsbG8=",mediaType:"text/plain",filename:"note.txt"}]; const entries=getPromptHistoryEntries([{type:"user",id:"file-only",historyId:"file-only",content:"",historySequence:1,fileParts}]); if (entries[0]?.fileParts?.[0]?.filename !== "note.txt") throw new Error("fileParts not preserved"); console.log("fileParts preserved");'./scripts/generate-version.sh && /Users/zhak/.npm/_npx/bb6645c1041000be/node_modules/.bin/bun run node_modules/@typescript/native-preview/bin/tsgo.js --noEmit -p tsconfig.main.jsongit diff --checkRisks
The UI is intentionally small and additive: users need to add/open the History tab from the right sidebar. The remaining #3416 ideas around persistent snippets and custom keybindings are not implemented here.
Generated with
mux• Model:GPT-5• Thinking:unknown• Cost:$unknown