Skip to content

🤖 fix: repair Nix native rebuild tooling#3406

Open
coadler wants to merge 1 commit into
mainfrom
build-native-xf7r
Open

🤖 fix: repair Nix native rebuild tooling#3406
coadler wants to merge 1 commit into
mainfrom
build-native-xf7r

Conversation

@coadler
Copy link
Copy Markdown
Collaborator

@coadler coadler commented May 27, 2026

Summary

  • Add Python to the Nix dev shell so node-gyp can rebuild Electron native modules.
  • Make make rebuild-native recover when a previous failed optional install left node-pty missing from node_modules.
  • Harden native-module presence checks and Nix format checking in temporary directories.

Background
This fixes the NixOS native rebuild path where node-gyp first failed without Python and then @electron/rebuild failed with ENOENT for node_modules/node-pty/package.json after the optional dependency was left missing.

Validation

  • make fmt-nix-check
  • nix develop --command make rebuild-native
  • make static-check

Generated with mux • Model: openai:gpt-5.5 • Thinking: xhigh • Cost: $0.00

@coadler
Copy link
Copy Markdown
Collaborator Author

coadler commented May 27, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant