Open
Conversation
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
toLiveBashOutputView was exported but never imported or called anywhere. Since LiveBashOutputInternal extends LiveBashOutputView, the WorkspaceStore returns the internal object directly (for reference stability with useSyncExternalStore), making this converter unnecessary.
…izePositiveIntOrNull normalizeAdvisorMaxUsesPerTurn and normalizeAdvisorMaxOutputTokens in AdvisorToolExperimentConfig.tsx had byte-for-byte identical bodies. Replace both with a single normalizePositiveIntOrNull helper.
mux-bot
bot
force-pushed
the
auto-cleanup
branch
from
771fa19 to
5b67455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Long-lived auto-cleanup PR that accumulates low-risk, behavior-preserving refactors picked from recent
maincommits.Current cleanup
Deduplicate identical
normalizeAdvisor*helpers (src/browser/features/Settings/Sections/AdvisorToolExperimentConfig.tsx)normalizeAdvisorMaxUsesPerTurnandnormalizeAdvisorMaxOutputTokenshad byte-for-byte identical function bodies (coerce a nullable number to a positive integer or return null). Replaced both with a singlenormalizePositiveIntOrNullhelper.Previous cleanups
Remove dead
toLiveBashOutputViewfunction (src/browser/utils/messages/liveBashOutputBuffer.ts)toLiveBashOutputViewwas exported but never imported or called anywhere in the codebase. SinceLiveBashOutputInternal extends LiveBashOutputView, theWorkspaceStore.getBashToolLiveOutputreturns the internal object directly for reference stability withuseSyncExternalStore, making this converter function unnecessary dead code.Validation
Auto-cleanup checkpoint: 7a2d18f
Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:$-