-
Notifications
You must be signed in to change notification settings - Fork 46
🤖 feat: dock/taskbar quick actions (open/new agent/quit) #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add Linux .desktop actions for launching a new agent window and quitting the app via CLI flags.\n\n---\n\n_Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `/A`_\n\n<!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=N/A -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2a6ef9c18
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Addressed the cold-start race where Start New Agent could fire before projects finished loading by buffering the request until ProjectContext loading completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 747575dfa9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
747575d to
998ca8f
Compare
|
@codex review Updated Start New Agent menu handler to buffer whenever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 998ca8febe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Buffer menu-triggered Start New Agent events as a count while projects are still loading, then drain them once projects are available. Also route start-workspace-creation to createWorkspaceDraft so repeated invocations are safe. --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `$N/A`_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=N/A -->
|
@codex review Fixed: buffer menu-triggered Start New Agent events as a count while projects are loading, then drain once loading completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 753207b772
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Fixed workspace creation prefill loss when startWorkspaceCreation creates/reuses a draft:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9322dadbb2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const draftId = createWorkspaceDraft(resolvedProjectPath); | ||
| persistWorkspaceCreationPrefill(resolvedProjectPath, detail, { draftId }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip Mux system project when starting new agent
When useStartWorkspaceCreation is invoked while the user is on the Chat with Mux workspace (or a desktop “Start New Agent” action uses the current selection), resolvedProjectPath can be the built‑in Mux system project because it exists in projects. This now creates a draft in that project, but the backend explicitly rejects workspace creation for that path (workspaceService.create returns “Cannot create workspaces in the Chat with Mux system project”), so the user lands in a draft flow that can never succeed and will error on create. Consider filtering out the system project or falling back to the first non‑system project before calling createWorkspaceDraft.
Useful? React with 👍 / 👎.
Summary
Adds OS-native app-icon quick actions so users can right-click the macOS Dock icon, Windows taskbar icon, or Linux launcher/taskbar and quickly:
Background
This makes common entrypoints faster (especially for starting a new agent) without needing to open the full UI first.
Implementation
--open--new-agent--quitsrc/desktop/main.ts):process.argvand thesecond-instancecommandLine.app.dock.setMenu)app.setUserTasks, packaged builds only)menu.onStartNewAgentbuild.linux.desktop) so the generated.desktopincludes actions for:mux --new-agent)mux --quit)Validation
make static-checkRisks
Exec=mux ...assumes the installed launcher command ismux(may differ for AppImage-style installs).Generated with
mux• Model:openai:gpt-5.2• Thinking:xhigh• Cost:$12.04