feat: conditionally add actor headers #142
Merged
+359
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
ssncferreira
approved these changes
Jan 23, 2026
Contributor
ssncferreira
left a comment
ssncferreira
left a comment
There was a problem hiding this comment.
Overall LGTM 👍 just some nits around header key/value sanitization. I know most of this is validated on the coder side, but since this is a library might be worth sanitizing or rejecting bad input.
|
|
||
| // Add headers for provided metadata. | ||
| for k, v := range actor.Metadata { | ||
| headers[ActorMetadataHeader(k)] = fmt.Sprintf("%v", v) |
Contributor
There was a problem hiding this comment.
nit: we should probably be sanitizing the headers/vallues to make sure they don't have whitespaces or invalid characters
Collaborator
Author
There was a problem hiding this comment.
Whitespace is fine in headers (well, not newlines) and I believe net/http takes care of invalid chars.
Collaborator
Author
There was a problem hiding this comment.
Or did you perhaps mean the header key?
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Jan 26, 2026
Also passes along the authenticated username as actor metadata. Closes coder/aibridge#135 Depends on coder/aibridge#142 **Replace aibridge tag with merge commit once coder/aibridge#142 lands.** --------- Signed-off-by: Danny Kopping <danny@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
Introduces a new header (
X-AI-Bridge-Actor-Id) which will optionally be sent along with upstream requests with the actor's identity as the value.Any metadata includes in the
context.Actorstruct will also be added to the headers in the formatX-AI-Bridge-Actor-{Key}={Value}.When enabled in
coder/coder, two new headers will be added: