feat(dashboard): maximize the Live View with Enter, restore with Esc#136
Merged
Conversation
43ae03c to
74e19e0
Compare
Press Enter — from the session list or the focused Live View — to maximize the selected session to the full dashboard body (the list is dropped); Esc restores the split view. Maximize is a modal layer that never mutates focus, so Esc returns to whatever was focused underneath. While maximized, panning and the z Overview toggle keep working and the header/footer stay; Tab/H/a are inert. The maximized pane keeps the split view's right edge so toggling never shifts the frame. Extracts the pane-dimension math into a tested paneLayout helper alongside listWidthFor, and shares the pan/overview key handling between the split and maximized input paths. Change-Id: I357f51ed22a5df02784213b3423df0240b805a96 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Kosiewski <tk@coder.com>
74e19e0 to
86474cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a maximize affordance to the read-only
dashboard's Live View. PressEnter— from the session list or the focused Live View pane — to blow the selected session's Live View up to the full dashboard body (the session list is dropped);Escrestores the split view.Behaviour
focus, so Esc returns you to whatever was focused underneath (list → list, pane → pane).↑/↓ h/j/k/l) and thezOverview toggle keep working; the header and footer stay;Tab/H/aare inert so it reads as a distinct mode.Design
Shipped after a prototype + a grilling session:
CONTEXT.mdis unchanged (the Live View is still clipped/panned/overview to fit a pane per ADR 0006; only the pane size changes).z/Overview scale toggle.maximizedboolean (a modal layer), not a 4thfocusvalue — its key target is identical tolive.Refactors (from a max-effort self-review)
paneLayout(termCols, termRows, maximized)helper besidelistWidthFor, with a unit test pinning the right-edge-stays-put invariant across the toggle.handlePanKeys/toggleOverview).Enterno-ops when no session is selected.Verification
typecheck·lint·format· 1375 unit tests (incl. 3 newpaneLayouttests) all green. Behaviour verified by hand against real sessions (the dashboard needs a real TTY; CI can't drive it).🤖 Generated with Claude Code