Conversation
…erence Enable users to configure embedding models across all providers (tfidf, fastembed, api) via CLAUDE_MEMORY_EMBEDDING_MODEL env var. The resolver now auto-infers the provider from the model name using the registry, so setting just the model name is sufficient. Key changes: - ModelRegistry: known models with dimensions, descriptions, size metadata - FastembedAdapter: dynamic dimensions from registry (was hardcoded 384) - Resolver: model-based provider inference, unified model forwarding - ApiAdapter: registry-backed dimensions (avoids probe API call) - EmbeddingsCommand: CLI for listing models and validating setup https://claude.ai/code/session_01DrjisFD2mvy2nvognHczbd
Replace stubs with real provider instances and real SQLiteStore databases. Fastembed tests use skip pattern (matching benchmarks/) when models can't be downloaded. EmbeddingsCommand tests use real tmpdir databases to verify dimension mismatch detection and database state display. https://claude.ai/code/session_01DrjisFD2mvy2nvognHczbd
check_dimension_compatibility and show_database_state opened SQLiteStore connections but only closed them in the happy path. On exception, the connection would leak. Wrap both in begin/ensure blocks.
…tion Move default model knowledge into ModelRegistry (single source of truth) instead of hardcoding adapter constants in EmbeddingsCommand. Extract with_each_store helper to eliminate duplicated store open/close/ensure loops in show_database_state and check_dimension_compatibility.
Move DB-reading and dimension-checking logic into a focused Inspector class that returns structured Data.define value objects. The command becomes a thin router (173 LOC, down from 239) that formats output. Inspector owns: with_each_store, database_states, dimension_checks. Store connection safety (ensure close) lives in one place now.
Fastembed::SUPPORTED_MODELS is a Hash, so use direct key lookup instead of iterating with find and accessing positional array elements.
…ance Extract resolve_or_skip helper in resolver_spec to eliminate 4 duplicated begin/rescue/skip blocks. Add rubocop disable comment to fastembed allow_any_instance_of (unavoidable: require is called inside initialize before an instance reference exists).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable users to configure embedding models across all providers (tfidf,
fastembed, api) via CLAUDE_MEMORY_EMBEDDING_MODEL env var. The resolver
now auto-infers the provider from the model name using the registry, so
setting just the model name is sufficient.
Key changes:
https://claude.ai/code/session_01DrjisFD2mvy2nvognHczbd