Skip to content

Fixed SpotBugs: Switch statement found where one case falls through t…#4400

Merged
shai-almog merged 1 commit intomasterfrom
fix-spotbugs-Switch-statement-found-where-one-case-falls-through-to-the-next-case
Jan 12, 2026
Merged

Fixed SpotBugs: Switch statement found where one case falls through t…#4400
shai-almog merged 1 commit intomasterfrom
fix-spotbugs-Switch-statement-found-where-one-case-falls-through-to-the-next-case

Conversation

@shai-almog
Copy link
Copy Markdown
Collaborator

…o the next case

@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Jan 11, 2026

Compared 30 screenshots: 30 matched.

Native Android coverage

  • 📊 Line coverage: 24.50% (2626/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.06% (12159/50528), branch 15.00% (701/4672), complexity 17.24% (731/4241), method 32.36% (589/1820), class 33.99% (103/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

  • 📊 Line coverage: 24.50% (2626/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
    • Other counters: instruction 24.06% (12159/50528), branch 15.00% (701/4672), complexity 17.24% (731/4241), method 32.36% (589/1820), class 33.99% (103/303)
    • Lowest covered classes
      • com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
      • com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
      • com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

@shai-almog shai-almog force-pushed the fix-spotbugs-Switch-statement-found-where-one-case-falls-through-to-the-next-case branch from 678c08b to c1f772f Compare January 11, 2026 19:27
@shai-almog
Copy link
Copy Markdown
Collaborator Author

shai-almog commented Jan 11, 2026

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

  • BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    BrowserComponent
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.

  • graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-arc
    Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.

  • graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-gradient
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.

  • graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

    graphics-draw-round-rect
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
    Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.

  • graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
    Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.

  • graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    graphics-draw-string-decorated
    Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
    Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.

  • kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

    kotlin
    Preview info: Preview provided by instrumentation.
    Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

  • VM Translation Time: 292 seconds
  • Compilation Time: 55 seconds

Detailed Performance Metrics

Metric Duration
Build Time Statistics
Setup & Unzip 26715 ms
Extract Extensions 14 ms
Google Services Setup 2 ms
Scan Classes 496 ms
Extract Libs 744 ms
Inject Build Hints 438 ms
Generate Unit Tests 4 ms
Generate Stubs 851 ms
Compile Stubs 1902 ms
Generate Icons 826 ms
Prepare ParparVM 176 ms
ParparVM Execution 174884 ms
Post-VM Setup 106 ms
CocoaPods 4356 ms
Finalize 23 ms
Total Time 211539 msMaven Overhead : 81000 ms
CocoaPods Install (Script) 1000 ms
Simulator Boot (Run) 42000 ms
App Install 30000 ms
App Launch 5000 ms
Test Execution 138000 ms

@shai-almog shai-almog force-pushed the fix-spotbugs-Switch-statement-found-where-one-case-falls-through-to-the-next-case branch from c1f772f to 1882f32 Compare January 12, 2026 02:24
@shai-almog shai-almog force-pushed the fix-spotbugs-Switch-statement-found-where-one-case-falls-through-to-the-next-case branch from 1882f32 to 11ebe53 Compare January 12, 2026 02:48
@github-actions
Copy link
Copy Markdown
Contributor

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Generated automatically by the PR CI workflow.

@shai-almog shai-almog merged commit 0991d8a into master Jan 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant