feat: only work with the last match in case where the regex contains global flag#27
Open
nsrCodes wants to merge 1 commit intocodemirror:mainfrom
Open
feat: only work with the last match in case where the regex contains global flag#27nsrCodes wants to merge 1 commit intocodemirror:mainfrom
nsrCodes wants to merge 1 commit intocodemirror:mainfrom
Conversation
…ion contains a global flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: codemirror/dev#1510
I have handled this explicitly for expressions with a global flag, but I feel the last match is the match that should be used in every case here.
The existing extra logic in
ensureAnchormakes me believe there are some conditions that I might not be aware of, hence the explicit global case.