Skip to content

chore: fixes for php-cs-fixer and psalm#10105

Merged
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:fix-cs-and-psalm
Apr 12, 2026
Merged

chore: fixes for php-cs-fixer and psalm#10105
paulbalandan merged 1 commit intocodeigniter4:developfrom
paulbalandan:fix-cs-and-psalm

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
I have included manual fixes, too.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@neznaika0
Copy link
Copy Markdown
Contributor

neznaika0 commented Apr 12, 2026

A small clarification - would a type without a variable be a serious violation? Or the opposite case - is it worth removing the variable if @var refers to the next line?

/** @var int $a */
$a = 123;
/** @var int */
$b = 456;

@paulbalandan
Copy link
Copy Markdown
Member Author

I'm not sure. It seems IDEs can still understand if the var name is omitted. Personally, I go with specifying the var name explicitly.

@paulbalandan paulbalandan merged commit 05a02c9 into codeigniter4:develop Apr 12, 2026
99 of 102 checks passed
@paulbalandan paulbalandan deleted the fix-cs-and-psalm branch April 12, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants