fix: validation when key does not exists#10006
Open
michalsn wants to merge 3 commits intocodeigniter4:developfrom
Open
fix: validation when key does not exists#10006michalsn wants to merge 3 commits intocodeigniter4:developfrom
michalsn wants to merge 3 commits intocodeigniter4:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where wildcard field validation (e.g.,
contacts.friends.*.name) silently skipped array elements that were missing the validated key whenever at least one sibling element had it present. Only the elements whose key existed in the data were validated. The rest were invisible to all rules.The root cause is that the validator builds
$valuesby filtering a flattened array - keys absent from the data simply never appear, so there is nothing to validate against. For non-wildcard fields, this is not a problem becausedot_array_search()already returnsnullfor a missing key. Wildcard fields had no equivalent treatment.Fixes #8006
Checklist: