Skip to content

support network_mode with service: mode only #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kim-codefresh wants to merge 9 commits into
base: master
Choose a base branch
from
Open

support network_mode with service: mode only #55

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7264f93
support network_mode with mode only
Sep 27, 2021
3a739a7
support network_mode with mode only
Sep 27, 2021
f4a6c5b
support network_mode with service: mode only
Sep 27, 2021
2d584bd
support network_mode with service: mode only
Sep 27, 2021
12f9270
support network_mode with service: mode only for hybrid
Sep 29, 2021
12e2721
support network_mode with service: mode only for hybrid
Sep 29, 2021
1f2e873
support network_mode with service: mode only for hybrid
Sep 29, 2021
b07d693
support network_mode with service: mode only for hybrid
Sep 29, 2021
1e78731
support network_mode for hybrid - the fix was made from engine
Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/model/parsers/ComposeV3/Service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,12 @@ class Service extends ServiceParser {
}
},
'network_mode': () => {
serviceInstance.setAdditionalData(fieldName, this._getAdditionalData(serviceInstance, fieldName, fieldValue));
const isPrivilegedModeSupported = accessibility.isPrivilegedModeSupported();
if (!isPrivilegedModeSupported && !fieldValue.startsWith('service:')) {
serviceInstance.setAdditionalData(fieldName, this._getAdditionalData(serviceInstance, fieldName, fieldValue));
}else{
serviceInstance.setAdditionalData(fieldName, fieldValue);
}
},
};
try {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cf-compose-model",
"version": "0.1.9",
"version": "0.1.10",
"description": "",
"main": "index.js",
"scripts": {
Expand Down