Skip to content

[Enhacement] - UI integration with PHA#352

Open
leekahung wants to merge 10 commits into
mainfrom
ui-integration-tfa-pha
Open

[Enhacement] - UI integration with PHA#352
leekahung wants to merge 10 commits into
mainfrom
ui-integration-tfa-pha

Conversation

@leekahung
Copy link
Copy Markdown
Contributor

@leekahung leekahung commented May 29, 2026

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Infrastructure
  • Maintenance

Description

This PR relates to UI updates for TFA, combining the designs from Amber and her implementation along with TFA. Additional changes will roll in as additional FAQs are provided by Amber; the current list for Frequent Inquries are tentative.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note on the devices and browsers this has been tested on, as well as any relevant images for UI changes.

The current version update for the UI is up in staging: https://staging.tenantfirstaid.com/

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests have not been included
  • I need help with writing tests

Documentation

  • If this PR changes the system architecture, Architecture.md has been updated

[optional] Are there any post deployment tasks we need to perform?

@leekahung leekahung marked this pull request as draft May 29, 2026 16:48
@leekahung leekahung requested review from wittejm and yangm2 and removed request for yangm2 June 2, 2026 02:39
@leekahung leekahung marked this pull request as ready for review June 2, 2026 02:39
@leekahung leekahung requested a review from yangm2 June 2, 2026 02:40
@leekahung leekahung changed the title [WIP] - UI integration with PHA [Enhacement] - UI integration with PHA Jun 2, 2026
Copy link
Copy Markdown
Contributor

@wittejm wittejm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall; I'll approve after this placeholder is filled.

answer: string;
}

// Placeholder Oregon-focused FAQ content. Pending review by a qualified
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just flagging this.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Jordan!

I received the list of questions Amber compiled from Michael a few days ago. I'll update it and ping them on it.

…Portland and Eugene notes; Improve FAQ accordion keyboard and screen-reader accessibility; Hide native scrollbars to prevent layout shift
@leekahung
Copy link
Copy Markdown
Contributor Author

Hey @TruMichael-jpg @michaelzhang43, I've folded in the questions Amber provided for the FAQs. I had Claude generate the answers for them, but I would like to have them verified.

Let me know if they look good (we can adjust them for correctness if needed). Check out the version on staging: https://staging.tenantfirstaid.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants