Remove showLLMFeatures feature flag#2142
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The LLM bill summaries and tags have been on for all environments for a while, so the gate isn't doing any work anymore. Drop the flag from FeatureFlags and the three env defaults, and inline the bill summary block in Summary.tsx without the surrounding conditional. Also drop the now-unused useFlags import. Closes codeforboston#2079. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
c-tonneslan
requested review from
Mephistic,
alexjball,
kiminkim724,
mertbagt,
mvictor55,
nesanders,
sashamaryl and
timblais
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #2079. The LLM bill summaries and tags have been on in all three environments (development, production, test) for a while, so the
showLLMFeaturesgate isn't doing anything anymore.showLLMFeaturesfrom theFeatureFlagsschema and from the three env defaultsSummary.tsx(no behavior change since the flag was on everywhere)useFlagsimport fromSummary.tsxI couldn't easily run
yarn check-typeslocally (yarn isn't on this machine) but the change is purely removing a flag whose only call site was the conditional I deleted, plus the import foruseFlagsthat was only used by that call site. Happy to add anything if CI catches something.Closes #2079.