Skip to content

Legislator page (header)#2122

Open
mertbagt wants to merge 25 commits into
codeforboston:mainfrom
mertbagt:legislator-header
Open

Legislator page (header)#2122
mertbagt wants to merge 25 commits into
codeforboston:mainfrom
mertbagt:legislator-header

Conversation

@mertbagt
Copy link
Copy Markdown
Collaborator

@mertbagt mertbagt commented May 6, 2026

Summary

Issue #2126

Checklist

  • On the frontend, I've made my strings translate-able.
  • [n/a] If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.
  • [n/a] If I've added new Firestore queries, I've added any new required indexes to firestore.indexes.json (Please do not only create indexes through the Firebase Web UI, even though the error messages may reccommend it - indexes created this way may be obliterated by subsequent deploys)

Screenshots

image image

Known issues

Followup PR:

  1. need to add Buttons
  2. need to update viableCourts variable from a static test value to an array of courts the legislator served on
    • need to calculate Terms Served and Incumbency off of firebase
  3. example: "District X * 9th Hampton" -> the database has the info for "9th Hampton" but it is unclear how to calculate X if we even have the necessary information to calculate X
  4. example: "State Representative * Springfield, Mass." need to move district off this line and add Town, Mass however we do not seem to have Town, Mass in the profile db.

Steps to test/reproduce

  1. Go to ./legislators/profile?id=XBPiuP0JN5ZwAMXb19j68GJduuO2

@vercel
Copy link
Copy Markdown

vercel Bot commented May 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maple-dev Ready Ready Preview, Comment May 13, 2026 1:47am

Request Review

@mertbagt mertbagt marked this pull request as draft May 6, 2026 18:24
@mertbagt mertbagt changed the title Legislator header Legislator Header May 6, 2026
@mertbagt mertbagt changed the title Legislator Header Legislator page (Header) May 6, 2026
@mertbagt mertbagt changed the title Legislator page (Header) Legislator page (header) May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant